Creating a Code Review Culture
summary
Explains concrete steps to build a code review culture: publish review values and create language and domain experts with pathways to certify them; use a PR template (example: Stripe/Julie Evans) and require authors to add context, annotate changes, and ship as vertical slices; keep large PR pain down, automate linters in CI and tests to remove nit comments, and take giant review threads offline (when you hit 50+ comments) to pair. Reviewers follow timed passes: size, context, relevance, readability, production readiness, tests, security, names and language-specific design.
AI-written summary · about
chapters (12)
- 0:00Creating a Code Review Culture Johnathan Turner Squarespace
- 0:48Code review is useful
- 1:34A code review culture is useful
- 2:47Organizations
- 3:03Be intentional about your culture
- 6:00Code authors
- 6:28Make the reviewer's life easier by communicating context
- 13:20Code reviewers
- 18:48Sizing up • What is the general shape of the PR? • Is the PR the right size?
- 22:52Production readiness • How will we know when this breaks? • Is there new documentation required by this change? • Are there tests that prevent regression? • Is this change secure?
- 27:03Language specific • Is the code well designed? • Is the code idiomatic to the language? • Are new patterns introduced? • Does the code fall into common pitfalls for the language?
- 28:20Full checklist at
related talks
38mImplementing a Strong Code-Review Culture
31mMay the Code Review Be with You
22mContinuous Improvements of The Code Review Process
22mBringing A Healthy Code Review Mindset to your team
01h 01mBetter Code Reviews FTW!
39mEffective Code Review
01h 05mGetting Good (or Better) at Code Reviews
20mConducting Humane Code Reviews