~/talk

How to effectively create and review PRs

Talkat droidcon San Francisco 2022 · 2022-06-02..06-03· [developer-experience]
slides:none on file

Advocates keeping PRs as small, focused units—split a feature into endpoint + models, storage/database, and UI PRs so feedback stays short and refactors are limited. Use GitHub features: put a PR template in .github, link issues to auto-close, and embed before/after screenshots or a markdown table for design changes. Reviewers choose between request changes / comment / approve based on crashes, missing tests, or nonblocking questions; authors open draft PRs to self-review, tag designers when needed, and prefix trivial suggestions with "nit."

AI-written summary · about

  1. 0:00Introduction
  2. 1:28PR size importance
  3. 7:08PR description tips
  4. 13:06Reviewing pull requests
  5. 17:21Final thoughts
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.