Keeping Code Style Sanity in a 13-year-old Codebase

on YouTube ↗24m

" summary

Shopify wrestles with a 13-year Ruby codebase of 700,000 lines and 400+ Rails developers, and introduces RuboCop plus a PR-only linter Felicia (policia) that comments or returns GitHub status. Adoption hits ~50% early; noise and legacy violations force rule pruning. Team enables auto-correct, runs correctable rules across the repo with a bot commit, makes remaining rules fail CI for new violations, adds caching to speed checks, and contributes fixes upstream so tooling scales without creating single-owner churn.

AI-written summary · about

" chapters (11)

1. 0:00Introduction and context
2. 1:16Why code style matters
3. 3:47History of Shopify’s code style
4. 5:58Introducing Felicia and Robocop
5. 8:05Shopify Ruby style guide launch
6. 11:37Surveying developer feedback
7. 13:24Fixing existing violations
8. 16:54Refining rules and strategy
9. 18:00Autocorrecting the codebase
10. 20:30Future improvements and caching
11. 21:34Takeaways and closing

" related talks

• 23mKeeping Code Style Sanity in a 13-year-old CodebaseGabi Stefanini · RubyConf Colombia 2017
• 33m​Keeping Code Style Sanity in a 10-year-old CodebaseGabi Stefanini · RailsConf 2017
• 23mEmbracing Code Quality with RubocopShloka Shah · RubyConf India 2023
• 31mHow GitHub uses lintersJoel Hawksley · RubyConf 2021
• 34mShitlist-driven development and other tricks for working on large codebasesFlorian Weingarten · RedDotRubyConf 2017
• 26mSemi Automatic Code ReviewRichard Huang · RailsConf 2012
• 34mShitlist-driven development and other tricks for working on large codebasesFlorian Weingarten · Red Dot Ruby Conference 2017
• 28mRESCUE SQUAD: Rails Edition!Ben Lovell · Ancient City Ruby 2015