You Came to a Python Conference. Now, Go Do a PR Review!
summary
Covers concrete PR-review actions: identifies three bad-review archetypes and prioritizes technical bugs vs nitpicks; walks through Python pitfalls with runnable examples — mutation model and default mutable args, when a function mutates an argument, and how many bugs that creates; shows idioms to replace loops with enumerate vs range and comprehensions; recommends stdlib tools like pathlib over os.path, collections.defaultdict, dataclasses and type annotations; explains which issues to block on now and which to note later so reviews become immediately actionable.
AI-written summary · about
chapters (10)
- 0:00PR reviews importance
- 1:47Why PR reviews critical
- 4:35Python traits for reviews
- 7:24Bad reviewer archetypes
- 12:18Python pass-by-reference quirks
- 15:48Default mutable pitfalls
- 16:29Idiomatic Python in reviews
- 19:56Leveraging Python standard library
- 24:04Communicating feedback
- 27:10Scaling impact via reviews
related talks
40mCode Review Skills for Pythonistas
18mHow To Review Someone's Code While Not Being A Jerk!
21mMaking the Most Out of Code Reviews
25mCode Review of Senior Python Engineers
49mBetter Code Reviews FTW!
24mDispelling The 'Genius Programmer' Myth Through Code Review
23mDrama-Free Code Review!
51mThe Perfect PR