~/talk

It Takes More Than LGTM to Do A Proper Code Review

Talkat JCON EUROPE 2024 · 2024-05-13..05-16· [developer-experience, soft-skills]
slides:none on file

An engineer recounts a real review that changes 6,000 lines and takes two weeks to review and then lays out concrete tactics: run CI, coverage and style checks automatically, keep style-only changes in separate PRs, use draft pull requests or feature branches to get early feedback, read tests first, and track metrics (lines changed, time-to-review, comments — GitLab shows merge requests taking 41 days). Practical, tool-specific fixes and measurable targets for reducing cycle time.

AI-written summary · about

  1. 0:00Introduction to code reviews
  2. 3:57Speaker background
  3. 5:01What is a code review
  4. 8:16Why we do code reviews
  5. 11:48Social aspects of reviews
  6. 17:03Automating code review tasks
  7. 18:30How I review code
  8. 21:20Preparing your pull request
  9. 23:06Promoting pull requests
  10. 25:13The problem with large PRs
  11. 28:50Solutions for large PRs
  12. 31:39Ideal PR size and workarounds
  13. 34:28Improving team alignment
  14. 36:14Using data to improve reviews
  15. 40:34Key takeaways
  16. 40:59Q&A session
~/search
type to search 6,249 conferences, 138,987 speakers and 185,172 talks
~/help
cmdctrl k
search every conference, speaker and series
/
focus the filter search
h
home
c
conferences
s
speakers
e
series
t
light / dark — the status bar button does the same
?
this help
esc
close this, then clear every filter — or just the search, while you are typing in it

Ignored while you are typing. Pages without a filter rail have no search to focus.