It Takes More Than LGTM to Do A Proper Code Review
summary
An engineer recounts a real review that changes 6,000 lines and takes two weeks to review and then lays out concrete tactics: run CI, coverage and style checks automatically, keep style-only changes in separate PRs, use draft pull requests or feature branches to get early feedback, read tests first, and track metrics (lines changed, time-to-review, comments — GitLab shows merge requests taking 41 days). Practical, tool-specific fixes and measurable targets for reducing cycle time.
AI-written summary · about
chapters (16)
- 0:00Introduction to code reviews
- 3:57Speaker background
- 5:01What is a code review
- 8:16Why we do code reviews
- 11:48Social aspects of reviews
- 17:03Automating code review tasks
- 18:30How I review code
- 21:20Preparing your pull request
- 23:06Promoting pull requests
- 25:13The problem with large PRs
- 28:50Solutions for large PRs
- 31:39Ideal PR size and workarounds
- 34:28Improving team alignment
- 36:14Using data to improve reviews
- 40:34Key takeaways
- 40:59Q&A session
related talks
32mLooks GREAT To Me: Getting Past Bare Minimum Code Reviews
41mCracking the Code Review from Guesswork to Automated Guidance
17mThe Perfect Code Review
01h 05mGetting Good (or Better) at Code Reviews
45mCracking the Code Review
46mLooks GREAT To Me: Getting Past Bare Minimum Code Reviews
44mEffective Code Review
47mGoldilocks and the Three Code Reviews
