Surprise! Neighboring Code Reviews
summary
Three internal Android apps (DMMポイントクラブ, DMMTV, DMMBOOK) present concrete code-review rules: PR size limits (~500 lines for DMMTV, ~200 for DMMBOOK), CI gating plus comment-triggered build checks, and mandatory two approvals before merge. Teams use Kotlin with MVVM and Kotlin Multiplatform for shared logic, plan migrations to Jetpack Compose, run two scheduled 30‑minute review sessions, attach screenshots/videos and self-checklists to PR templates, and use LeakCanary plus scenario tests to detect performance and UI regressions.
AI-written summary · about
chapters (19)
- 0:00Introduction
- 1:25Code review pros and cons
- 4:11Android team structure
- 5:37Points club review case
- 9:57Review time tips
- 10:19DMMTV review case
- 14:16Bias in reviews
- 15:00dmmbook review case
- 19:40Team review tips
- 21:11Reviewer efforts
- 24:24Alignment and communication
- 26:32Recording knowledge
- 26:53Smooth review goals
- 28:59Comfortable communication
- 30:48Reviewer initiatives
- 34:24Reviewability improvements
- 35:50Review as compassion
- 37:33Android review points
- 38:16Summary
related talks
41mReviewing Kotlin
36mCode review for Android is broken
46mGetting the most out of code review
38mCode Quality on Android - A grumpy old man's perspective
40mCase Study- How Android Platform @ Reddit learned to stop worrying and embrace DevX
31mMay the Code Review Be with You
43mCode Review Tools
23mDrama-Free Code Review!