Pull Requests and Reviews for Good
summary
Explains how to prepare pull requests so they merge: clear goal and design, small logical commits, tests, user and developer docs, and supportability that comes with a Reviewed-by endorsement; reviewers focus on correctness, invariants, interfaces, coding style and commit history and ask clarifying questions rather than dictate changes. Cites case studies: a replica-read performance change (an ~800-line PR with median commit ~9 lines), Crush multi-step retry work, and stretch mode implemented via coordinated monitor and OSD patches that include tests and followups.
AI-written summary · about
chapters (7)
- 0:00Introduction to PRs
- 6:43Reviewer responsibilities
- 16:09Submitter responsibilities
- 22:11Communicating respectfully
- 28:15Case studies on PRs
- 35:22Stretch mode implementation
- 37:55Q&A and closing
related talks
30mEffective Pull Request Reviews
11mPull Requests: Merge With Your Team
28mPull Requests: Merging good practices into your project
21mA Guide to Perfecting Pull Requests
29mThe Art of Humanizing Pull Requests (PR’s)
57mA Meritocracy of Pull Requests
38mCode Review vs Pul Requests
29mThe art of humanizing Pull Requests (PR’s)